Skip to content

OUTPUTS seems to be String not PSPipeline#17287

Merged
BethanyZhou merged 1 commit intoAzure:mainfrom
ecormaksin:patch-2
Mar 2, 2022
Merged

OUTPUTS seems to be String not PSPipeline#17287
BethanyZhou merged 1 commit intoAzure:mainfrom
ecormaksin:patch-2

Conversation

@ecormaksin
Copy link
Contributor

@ecormaksin ecormaksin commented Mar 1, 2022

Description

When I execute Invoke-AzDataFactoryV2Pipeline, String was returned. So, OUTPUTS seems to be System.String not Microsoft.Azure.Commands.DataFactoryV2.Models.PSPipeline.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • [-] The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • [-] The PR does not introduce breaking changes
  • [-] If applicable, the changes made in the PR have proper test coverage
  • [-] For public API changes to cmdlets:
    • [-] a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • [-] the markdown help files have been regenerated using the commands listed here

@ecormaksin
OUTPUTS seems to be String not PSPipeline
71a04a8 
When I execute `Invoke-AzDataFactoryV2Pipeline`, String was returned. So, OUTPUTS seems to be System.String not Microsoft.Azure.Commands.DataFactoryV2.Models.PSPipeline.
@ghost ghost added the customer-reported label Mar 1, 2022
@ghost
Copy link

ghost commented Mar 1, 2022

Thank you for your contribution ecormaksin! We will review the pull request and get back to you soon.

@BethanyZhou
Copy link
Contributor

BethanyZhou commented Mar 1, 2022 •
edited
Loading

Hi @ecormaksin , you are right. The output type of Invoke-AzDataFactoryV2Pipeline is string. Except correct it from docs level, we also need to correct it from code level, could you kindly help us?

azure-powershell/src/DataFactory/DataFactoryV2/Runs/InvokeAzureDataFactoryPipelineCommand.cs

Line 29 in 1c0844a

[Cmdlet("Invoke", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "DataFactoryV2Pipeline", DefaultParameterSetName = ParameterSetNames.ByFactoryNameByParameterFile, SupportsShouldProcess = true), OutputType(typeof(PSPipeline))]

FYI, @Jingshu923 .

@BethanyZhou BethanyZhou self-assigned this Mar 1, 2022
@ecormaksin
Copy link
Contributor Author

ecormaksin commented Mar 2, 2022

@BethanyZhou I'm sorry, I have little time to work with this. Because I have no experience C#, and I cannot grasp whole product, and I don't know quickly whether I have to change other components (sources, docs), please reject this pull request, and fix by yourselves.

@BethanyZhou
Copy link
Contributor

BethanyZhou commented Mar 2, 2022

@ecormaksin Thank you again for reporting this issue and we are happy you joined us to refine our product. Let's accept this PR. And I will fix this issue from code level soon by myself.

@BethanyZhou
Copy link
Contributor

BethanyZhou commented Mar 2, 2022

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented Mar 2, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@BethanyZhou BethanyZhou merged commit 041a918 into Azure:main Mar 2, 2022
@BethanyZhou BethanyZhou mentioned this pull request Mar 4, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@BethanyZhou BethanyZhou BethanyZhou approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@BethanyZhou BethanyZhou

Labels

customer-reported Waiting for CI :shipit:

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ecormaksin @BethanyZhou